From 858612fa8e44034edf22cd689bcb282df7bd1bfe Mon Sep 17 00:00:00 2001
From: lincube <lincube3@hotmail.com>
Date: Mon, 20 Apr 2026 07:55:56 +0800
Subject: [PATCH] fix: make optional s3 upload step workflow-parse safe

---
 .github/workflows/release.yml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index cb383ff..fd28a6d 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -901,7 +901,7 @@ jobs:
           fi
 
       - name: Upload Incremental Assets to S3 (optional)
-        if: ${{ vars.S3_ENDPOINT != '' && vars.S3_BUCKET != '' && secrets.S3_ACCESS_KEY != '' && secrets.S3_SECRET_KEY != '' }}
+        if: ${{ vars.S3_ENDPOINT != '' && vars.S3_BUCKET != '' }}
         env:
           S3_ENDPOINT: ${{ vars.S3_ENDPOINT }}
           S3_BUCKET: ${{ vars.S3_BUCKET }}
@@ -911,6 +911,12 @@ jobs:
           S3_OBJECT_PREFIX: lanmountain/distribution-v1
         run: |
           set -euo pipefail
+
+          if [ -z "${S3_ACCESS_KEY:-}" ] || [ -z "${S3_SECRET_KEY:-}" ]; then
+            echo "S3 credentials are not configured. Skipping optional S3 upload step."
+            exit 0
+          fi
+
           python3 -m pip install --upgrade awscli
 
           mkdir -p release-update-assets